GitHub user mike-jumper opened a pull request:
https://github.com/apache/guacamole-client/pull/282
GUACAMOLE-220: Extract common base for management UI.
A necessary basis for the user group management interface (which adds yet
another management tab), these changes extract the common base code used by the
various existing management tabs, which up until now has been largely
duplicated.
New directives have been added to take care of data source tabs, permission
management, and the save/cancel/clone/delete buttons. The permission test logic
driving those buttons and other parts of each management tab has been moved
into common class, as well.
This is a net increase in code due to the amount of documentation added,
and a massive net decrease in the amount of code within the management
controllers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/guacamole-client extract-common-ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #282
----
commit 94ad1f9f349826ede932ea843ed87f58cc76d598
Author: Michael Jumper <mjumper@...>
Date: 2018-04-29T06:05:27Z
GUACAMOLE-220: Separate system/connection permission editing into
directives.
commit 507202d1f3c6b5e96e9f2a6d6f341331af9d34c0
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T06:24:15Z
GUACAMOLE-220: Define abstract object for querying the management-related
actions a user may take on a particular object or type of object.
commit 4f43ddc4203a59c7aea6834cfd8b5961c74ba57e
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T07:03:52Z
GUACAMOLE-220: Migrate user management controller to ManagementPermissions.
commit e045da132c729d0567f256708d204d607c053f9f
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T16:46:46Z
GUACAMOLE-220: Add common directive for displaying the
save/clone/cancel/delete buttons shared by all object management pages.
commit 0414cdd3edc4f5ba11900750ed26782e335de7b2
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T16:53:26Z
GUACAMOLE-220: Migrate user management screen to new, common management
button directive.
commit 331f46d61010e38cfeb8acb5cb3d4b40fde10de2
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T18:22:31Z
GUACAMOLE-220: Migrate connection management screen to common buttons and
permission logic.
commit a21c7f1a84a793135ffa27bb1e2b565f6dcd1805
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T18:54:38Z
GUACAMOLE-220: Migrate connection group management screen to common buttons
and permission logic. Add required clone option.
commit bf4fdd6a9bd11fce7da0419e56dc502da6956c5c
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T19:24:33Z
GUACAMOLE-220: Migrate sharing profile management screen to common buttons
and permission logic.
commit 5ab4ae8625e00bbdbb69bdd06eda19903e46d927
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T19:42:36Z
GUACAMOLE-220: Move common protocol namespace/name retrieval to Protocol
class.
commit e071ceaedd3da4439f97a156fc0bdfac23b93b5c
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T23:29:25Z
GUACAMOLE-220: "Management", not "managment".
commit b1600bf13ddf015eae64fe5acdf0463e462412cb
Author: Michael Jumper <mjumper@...>
Date: 2018-05-01T23:39:02Z
GUACAMOLE-220: Include the identifier of the associated object within
ManagementPermissions.
commit 8f6dd666f0f603242615ebbdab20c283d8f9f2b7
Author: Michael Jumper <mjumper@...>
Date: 2018-05-02T00:18:48Z
GUACAMOLE-220: Move data source tabs to separate directive.
commit b0a625cdeac44be74fa3a75cec317f10e6620bca
Author: Michael Jumper <mjumper@...>
Date: 2018-05-02T00:19:40Z
GUACAMOLE-220: Remove unnecessary userExists() function.
----
---
