Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/167#discussion_r188933435
  
    --- Diff: src/protocols/ssh/settings.c ---
    @@ -217,6 +218,12 @@ enum SSH_ARGS_IDX {
          */
         IDX_BACKSPACE,
     
    +    /**
    +     * The terminal emulator type that is passed to programs (e.g. "xterm" 
or
    --- End diff --
    
    So, I have one minor nitpick about this comment - Guacamole is not actually 
passing the terminal emulator type to any particular program(s), this simply 
passes it to the system - it's up to the system to make it available to the 
programs.  Perhaps "passed to the remote system" would be better?


---

Reply via email to