Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/164#discussion_r189492258
  
    --- Diff: src/common-ssh/ssh.c ---
    @@ -414,7 +415,8 @@ static int 
guac_common_ssh_authenticate(guac_common_ssh_session* common_session)
     }
     
     guac_common_ssh_session* guac_common_ssh_create_session(guac_client* 
client,
    -        const char* hostname, const char* port, guac_common_ssh_user* 
user, int keepalive) {
    +        const char* hostname, const char* port, guac_common_ssh_user* 
user, int keepalive,
    +        const int host_key_type, const char* host_key) {
    --- End diff --
    
    Perhaps the new connection parameter should be in the same format as the 
`known_hosts` file (via 
[`libssh2_knownhost_readline()`](https://www.libssh2.org/libssh2_knownhost_readline.html))?
 That would eliminate the need for specifying the key type, and would provide 
for specifying multiple keys.


---

Reply via email to