GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/292
GUACAMOLE-524: Add attributes to credentials and token filter
This is the first in a set of at least a couple of pull requests that
allows user attributes retrieved in various authentication extensions to be
used in the `TokenFilter` class so that they can be used by connections
provided by other extensions. This change adds the attributes `Map` to the
`Credentials` object, along with methods for interacting with it, and also adds
the changes into the `TokenFilter` and `StandardToken` classes to map those
attributes to token values.
With these changes, if an attribute is added to a `Credentials` object with
a key of "email" and a value of "[email protected]", the token
`${GUAC_ATTR:EMAIL} would then substitute in the value "[email protected]".
Assuming this is acceptable, the next pull request or two would add support
to various authentication modules for configuring and retrieving attributes and
adding them to the `Credentials` object so that they can be used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/guacamole-client jira/524
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #292
----
commit 49e8f43961c5ed03584cfa5d12f503e5cc527fef
Author: Nick Couchman <vnick@...>
Date: 2018-06-05T00:37:23Z
GUACAMOLE-524: Add attribute map to Credentials object.
commit 7a75825da0b8972aba81c6c62e26b15c9cd536dc
Author: Nick Couchman <vnick@...>
Date: 2018-06-05T01:01:38Z
GUACAMOLE-524: Add methods for tokenizing arbitrary attributes.
commit 746407a6dbd903b5b4d9f1e1547efdd7f571f523
Author: Nick Couchman <vnick@...>
Date: 2018-06-05T01:13:58Z
GUACAMOLE-524: Add method for overlaying existing attributes with current
ones, and beef up documentation a bit.
commit 2fcdfc9301cc8eb805e7d48b912701b7a034171f
Author: Nick Couchman <vnick@...>
Date: 2018-06-05T01:19:40Z
GUACAMOLE-524: Slight tweak to attribute prefix.
----
---
