Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/173#discussion_r196231052
  
    --- Diff: src/terminal/terminal/terminal.h ---
    @@ -568,17 +576,97 @@ int guac_terminal_printf(guac_terminal* terminal, 
const char* format, ...);
     
     /**
      * Handles the given key event, sending data, scrolling, pasting clipboard
    - * data, etc. as necessary.
    + * data, etc. as necessary. If terminal input is currently coming from a
    + * stream due to a prior call to guac_terminal_send_stream(), any input
    + * which would normally result from the key event is dropped.
    + *
    + * @param term
    + *     The terminal which should receive the given data on STDIN.
    + *
    + * @param user
    + *     The user that originated the key event.
    + *
    + * @param keysym
    + *     The X11 keysym of the key that was pressed or released.
    + *
    + * @param pressed
    + *     Non-zero if the key represented by the given keysym is currently
    + *     pressed, zero if it is released.
    + *
    + * @return
    + *     Zero if the key event was handled successfully, non-zero otherwise.
      */
     int guac_terminal_send_key(guac_terminal* term, int keysym, int pressed);
     
     /**
      * Handles the given mouse event, sending data, scrolling, pasting 
clipboard
    - * data, etc. as necessary.
    + * data, etc. as necessary. If terminal input is currently coming from a
    + * stream due to a prior call to guac_terminal_send_stream(), any input
    + * which would normally result from the mouse event is dropped.
    + *
    + * @param term
    + *     The terminal which should receive the given data on STDIN.
    + *
    + * @param user
    + *     The user that originated the mouse event.
    + *
    + * @param x
    + *     The X coordinate of the mouse within the display when the event
    + *     occurred, in pixels. This value is not guaranteed to be within the
    + *     bounds of the display area.
    + *
    + * @param y
    + *     The Y coordinate of the mouse within the display when the event
    + *     occurred, in pixels. This value is not guaranteed to be within the
    + *     bounds of the display area.
    + *
    + * @param button_mask
    --- End diff --
    
    `mask`. Copypasta for sure. Will fix this, too.


---

Reply via email to