Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/301#discussion_r196266846
--- Diff:
guacamole/src/main/webapp/app/navigation/services/userPageService.js ---
@@ -257,15 +257,23 @@
angular.module('navigation').factory('userPageService', ['$injector',
canManageConnections.push(dataSource);
}
- // Determine whether the current user needs access to the
session management UI or view connection history
+ // Determine whether the current user needs access to view
connection history
if (
- // A user must be a system administrator to manage
sessions
+ // A user must be a system administrator to view
connection records
PermissionSet.hasSystemPermission(permissions,
PermissionSet.SystemPermissionType.ADMINISTER)
) {
- canManageSessions.push(dataSource);
canViewConnectionRecords.push(dataSource);
}
+ // Determine whether the current user needs access to view
session management
+ if (
+ // Permission to manage active sessions.
+ PermissionSet.hasSystemPermission(permissions,
PermissionSet.SystemPermissionType.ADMINISTER)
+ ||
PermissionSet.hasActiveConnectionPermission(permissions,
PermissionSet.ObjectPermissionType.DELETE)
--- End diff --
For that case, I think we're relatively stuck until something like the
proposed automatic-joining functionality is implemented.
I don't think there should be a disconnect loop, though. IIRC, the recent
improvements to RDP error handling will cause Guacamole to not automatically
reconnect when the user is kicked off specifically because another user has
started a session.
---
