Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/304#discussion_r197609311
  
    --- Diff: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
 ---
    @@ -283,7 +284,12 @@ public AuthenticatedUser authenticateUser(Credentials 
credentials)
             try {
                 // Get LDAP attributes by querying LDAP
                 LDAPEntry userEntry = ldapConnection.read(userDN, attrArray);
    +            if (userEntry == null)
    +                return null;
    --- End diff --
    
    I'm good with returning an empty map - I've updated the changes, here, to 
do that instead of null.


---

Reply via email to