GitHub user mike-jumper opened a pull request:
https://github.com/apache/guacamole-server/pull/176
GUACAMOLE-573: Correct scrollback buffer bounds checks.
The new bounds checks added for copying text from the scrollback buffer are
incorrect for the case where the number of rows in scrollback has not yet
reached at least the size of the terminal window. These changes remove those
incorrect checks, instead modifying scrollback buffer row retrieval such that
it is guaranteed to stay within bounds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/guacamole-server
correct-bounds-checks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-server/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit b0b0b186f5f9e57bfe93ed96c8c3a1e9fc4f192b
Author: Michael Jumper <mjumper@...>
Date: 2018-07-18T04:55:46Z
GUACAMOLE-573: Ensure scrollback buffer bounds cannot be exceeded. Remove
incorrect bounds checks.
----
---
