GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-client/pull/307

    GUACAMOLE-598: Display fatal error if a page is unusable / nonfunctional.

    These changes add a new `requestService.DIE` constant which can be used in 
favor of `requestService.WARN` if failure of the request in question will 
result in the page being useless. The various usages of `requestService.WARN` 
have been updated to `requestService.DIE` where appropriate.
    
    Unlike `requestService.WARN`, which only logs a warning to the browser 
console, `requestService.DIE` replaces the current page with a generic error:
    
    
![guac-generic-error](https://user-images.githubusercontent.com/4632905/43348191-b0f83c8c-91ad-11e8-8f82-f08b752bf98d.png)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-client fatal-page-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #307
    
----
commit 4bc7700d575bcf7001997aa019b0c91768092673
Author: Michael Jumper <mjumper@...>
Date:   2018-06-27T05:45:28Z

    GUACAMOLE-598: Add absolute, global, fatal error handling.

commit c897c7eb261a70f1c5d7bb8d839d7080b4cd0e24
Author: Michael Jumper <mjumper@...>
Date:   2018-06-27T05:45:52Z

    GUACAMOLE-598: Add convenience promise callback for REST requests which 
displays a fatal error.

commit 5866c7e251f05c9345f77215713d4549575db2df
Author: Michael Jumper <mjumper@...>
Date:   2018-06-27T05:49:06Z

    GUACAMOLE-598: Abort rendering of pages if critical data fails to load 
(data without which the page is non-functional).

----


---

Reply via email to