[GitHub] guacamole-client pull request #308: GUACAMOLE-593: Allow group membership at...

[necouchman]

Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/308#discussion_r206498251
  
    --- Diff: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
 ---
    @@ -257,7 +260,10 @@ private String getConnectionSearchFilter(String userDN,
                 LDAPSearchResults userRoleGroupResults = ldapConnection.search(
                     groupBaseDN,
                     LDAPConnection.SCOPE_SUB,
    -                "(&(!(objectClass=guacConfigGroup))(member=" + 
escapingService.escapeLDAPSearchFilter(userDN) + "))",
    +                "(&(!(objectClass=guacConfigGroup))(" 
    +                        + confService.getMemberAttribute() 
    --- End diff --
    
    Escaped.


---