GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-client/pull/315

    GUACAMOLE-220: Correct handling of permission-filtered directory search.

    This change uses the correct `ObjectPermissionSet` to filter the 
identifiers of objects listed via REST when permission filtering is requested.
    
    Previous code was always using the `ObjectPermissionSet` returned by 
`getUserPermissions()`, but this is only correct for user objects and thus was 
incorrect for all other object types (connections, connection groups, etc.). 
This bug likely went unnoticed due to minimal use of permission filtering, 
however it affects the behavior of the admin interface with respect to managing 
group memberships.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-client fix-perm-filter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #315
    
----
commit 2161260e34505d7f30ba22cdfde5f19c71de4626
Author: Michael Jumper <mjumper@...>
Date:   2018-09-08T20:04:25Z

    GUACAMOLE-220: Correct handling of permission-filtered directory search.
    
    The correct ObjectPermissionSet should be used to filter the identifiers
    used. Previous code was always using the ObjectPermissionSet specific to
    permissions affecting user objects, and thus was incorrect for all other
    types of objects (connections, connection groups, etc.).

----


---

Reply via email to