Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/187#discussion_r217195956
--- Diff: src/protocols/telnet/settings.c ---
@@ -196,12 +198,31 @@ enum TELNET_ARGS_IDX {
*/
IDX_SCROLLBACK,
+ /**
+ * The regular expression to use when searching for whether login was
+ * successful. This parameter is optional. If given, the
+ * "login-failure-regex" parameter must also be specified, and the
first
+ * frame of the Guacamole connection will be withheld until login
+ * success/failure has been determined.
+ */
+ IDX_LOGIN_SUCCESS_REGEX,
+
+ /**
+ * The regular expression to use when searching for whether login was
+ * unsuccessful. This parameter is optional. If given, the
+ * "login-failure-regex" parameter must also be specified, and the
first
--- End diff --
Copy pasta. I think this should say
> "login-success-regex" pararameter must also be specified...
---
