Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/319#discussion_r220513791
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml ---
@@ -109,33 +109,33 @@
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis</artifactId>
- <version>3.2.8</version>
+ <version>3.4.6</version>
--- End diff --
Looking at the POM file it looks like there are certain features of this
version of MyBatis that aren't usable with older versions of Java. There's a
block toward the bottom that excludes certain code file from the compile when
the version is 1.6 and a block that excludes for 1.7. It's possible I was
using a feature that isn't available in 1.6, even if the overall project is
compatible with it. It also looks like the test suite requires at least 1.7,
so maybe that is what I was seeing before.
I definitely am more inclined toward moving on to 1.7 or 1.8 given the age
of 1.6 (and even 1.7), but I also understand maintaining compatibility as much
as possible. However, it does seem like several aspects of the web app are
using some features that require 1.7 or 1.8, and there are also some Java
syntax features that we would probably benefit from by moving on to the higher
versions. Two that come to mind are "try with resources" and the ability to
handle multiple exception types in a single `catch` block.
---
