GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-client/pull/330

    GUACAMOLE-232: Mark key as implicitly pressed only when pressed due to 
another, identifiable key event.

    On iOS, distinct key events are sent for modifier keys, but these key 
events take the form of empty events with only modifier flags set. The current 
`Guacamole.Keyboard` implicit key logic seems correct, but a key event which 
has absolutely no information except modifier flags shouldn't be considered 
implicit; it's an explicit event for the specific modifiers involved.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-client 
keyboard-regression

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #330
    
----
commit e3c1b6ac98db62fa5c05c6c752d7d0843fb4894a
Author: Michael Jumper <mjumper@...>
Date:   2018-10-04T04:30:02Z

    GUACAMOLE-232: Mark key as implicitly pressed only when pressed due to 
another, identifiable key event.

----


---

Reply via email to