Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/199#discussion_r231131516
--- Diff: src/protocols/ssh/ssh.c ---
@@ -320,6 +320,17 @@ void* ssh_client_thread(void* data) {
return NULL;
}
+ /* Forward specified locale */
+ if (settings->locale != NULL) {
+ if (libssh2_channel_setenv(ssh_client->term_channel, "LANG",
+ settings->locale)) {
+ guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR,
--- End diff --
Should this really be a fatal error in terms of the overall connection? I
ask because in general this is not fatal in terms of other SSH clients - for
example, if you use the "ssh" command on pretty much any platform and ask to
forward a variable that the server does not allow, it is simply silently
ignored and does not abort the connection.
---
