On Sat, Nov 17, 2018 at 9:04 PM Roman Shaposhnik <[email protected]> wrote:
> On Sat, Nov 17, 2018 at 7:15 PM Mike Jumper <[email protected]> wrote: > > > > On Sat, Nov 17, 2018 at 2:59 PM Roman Shaposhnik <[email protected]> wrote: > > > > > Hi! > > > > > > I was very pleasantly surprised to discover that Kubernetes > > > container TTY support is now part of Guacamole. The JIRA, > > > however, talks about both Docker Engine and Kubernetes. > > > Looking at the source code I'm not sure I see the code that > > > would talk to Docker Engine. Am I missing something? > > > > > > > > What JIRA issue are you referring to? The one I have in front of me is > > Kubernetes-specific: > > > > https://issues.apache.org/jira/browse/GUACAMOLE-623 > > I was looking at: https://jira.glyptodon.org/browse/GUAC-1658 > > The JIRA at jira.glyptodon.org is the JIRA instance for Glyptodon, Inc. It was used by the Guacamole project before it moved to the ASF and became Apache Guacamole. That JIRA continues to be used by Glyptodon to track downstream work/contributions, while the correct JIRA instance for the upstream project is the one hosted by the ASF at issues.apache.org: https://issues.apache.org/jira/browse/GUACAMOLE As I worked on both of the above (GUAC-1658 was the issue that tracked this work for my day job at Glyptodon), I can hopefully clarify the difference between the two issues' scopes: The original downstream motivation for the task was to add Kubernetes support. Early research lead me to believe that doing so would involve Docker to such an extent that support for both Docker and Kubernetes would be equivalent and implemented simultaneously. As it turns out, the two have very different APIs when it comes to attaching to the console of a container, and the scope had to be tightened to strictly Kubernetes. Similar support could certainly be added for Docker containers, as well, but would need to be tackled separately. - Mike
