Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r236385213
--- Diff: src/guacd/conf-file.c ---
@@ -188,15 +188,21 @@ guacd_config* guacd_conf_load() {
conf->key_file = NULL;
#endif
+ /* Determine path of configuration file */
+ if(conf_file_path == NULL) {
--- End diff --
Two issues, here:
* If is not a function...
`if (conf_file_path == NULL) {`
* Why do this particular check, here? Why not always make sure this
function is fed a path, and then upstream feed either the provided location or
the constant `GUACD_CONF_FILE`?
---
