Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/345#discussion_r241932591
  
    --- Diff: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
 ---
    @@ -240,17 +244,24 @@ public LDAPAuthenticatedUser 
authenticateUser(Credentials credentials)
     
             try {
     
    +            LdapConnectionConfig ldapConnectionConfig =
    +                    ((LdapNetworkConnection) ldapConnection).getConfig();
    +            Dn authDn = new Dn(ldapConnectionConfig.getName());
    --- End diff --
    
    So I took one stab at a way to do this, storing a `Dn` object called 
`bindDn` in the `LDAPAuthenticatedUser` class.  I'm not sure it's the right way 
to go (and haven't tested it to make sure it works), but let me know if that 
seems reasonable or if I should try another route.
    
    I also thought about creating a new `LDAPCredentials` class that extends 
`Credentials` and adding the bindDn into that, but that would require importing 
other things (JAX-RS) into the guacamole-auth-ldap module, and that seemed like 
a lot of extra stuff just to find a place to store the bind DN.
    
    I'm open to other suggestions.


---

Reply via email to