Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/205#discussion_r244047256
--- Diff: src/guacd/conf-file.h ---
@@ -32,10 +37,17 @@
int guacd_conf_parse_file(guacd_config* conf, int fd);
--- End diff --
My only comment here would be to stay consistent with how this is done
elsewhere in the code. Are other functions hidden using static, or just not
stubbed in header files? Go with the route that provides the most consistency,
unless there's a really good reason to do otherwise.
---
