mike-jumper commented on issue #340: GUACAMOLE-660: Add Urdu Language Support URL: https://github.com/apache/guacamole-client/pull/340#issuecomment-453867532 OK - things look generally good code-wise, but I'm seeing a few issues when testing this new support. Most appear to be unexpected results of RTL text. 1. The icon indicating a field used for searching/filtering is still left-justified despite RTL text direction.   2. The text of the connection status dialog is still left-justified despite RTL text direction.  3. When Urdu is selected, the pagination buttons point weirdly inward.  4. Connection duration is still in English (and backwards due to RTL).  5. Connection lists are still left-justified despite RTL text direction, and the expand button and tree lines for connection hierarchies is misaligned.  6. The menu icons are on the left side of the text despite RTL text direction. 
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
