daniquir commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456172559 Like you have been able to verify it's a very laborious and extensive work. I take into account everything you mention about refactoring the nomenclature of the project, it's something I have pending, along with reviewing the documentation of the JavaDoc, the format, etc. Before finishing the development of those things I wanted them to be reviewed by you in case I still had to make a big change and I did not have to revise the whole project for these things that you mentioned. In any case, I will be available for what is necessary in order to modify and give support in this adaptation. I keep revising the code and testing the application, since it practically affects everything. Regarding your doubts, I answer you below. The reason why there are interfaces and empty classes is being able to share the code in a generic way with the extension of Morphia/MongoDB, since the data structure is not exactly the same because the relationships between entities are done by objects. I would like you to clarify a bit this phrase: "In multiple places you've broken the import blocks into multiple sections, which is not consistent with the style in the rest of the code." From what I understand you mean the import of the classes and interfaces, in the upper part, this may have been done by the auto-import of eclipse, I will take it into account to correct it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
