necouchman commented on issue #359: GUACAMOLE-617: Extract Permission 
Management from JDBC Authentication Module
URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456212242
 
 
   > Before finishing the development of those things I wanted them to be 
reviewed by you in case I still had to make a big change and I did not have to 
revise the whole project for these things that you mentioned.
   
   I would advise you to go ahead with these changes.  There are going to be 
several revisions, I'm sure, but it's hard to review the code partially.
   
   > From what I understand you mean the import of the classes and interfaces, 
in the upper part, this may have been done by the auto-import of eclipse, I 
will take it into account to correct it.
   
   Yeah, that makes sense if the IDE is trying to split it up.  I'm guessing it 
may be doing the same thing to your indentations - there might be some settings 
in Eclipse that control these behaviors.  I use Netbeans, and some of it is 
configurable, and some of it it tries to guess from the existing code.  Doesn't 
always do exactly what I want it to do, but mostly it works.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to