JoelB commented on a change in pull request #371: GUACAMOLE-717: Handle 
LDAPException gracefully when doing a search
URL: https://github.com/apache/guacamole-client/pull/371#discussion_r251168667
 
 

 ##########
 File path: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
 ##########
 @@ -220,6 +220,9 @@ public String generateQuery(String filter,
                         logger.warn("Given a referral, but referrals are 
disabled. Error was: {}", e.getMessage());
                         logger.debug("Got a referral, but configured to not 
follow them.", e);
                     }
+                } catch (LDAPException e) {
 
 Review comment:
   Fixed.  What do you think about adding a link to those coding guidelines in 
the CONTRIBUTING document?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to