necouchman commented on a change in pull request #214: GUACAMOLE-381: Add
parameters for disabling clipboard copy/paste.
URL: https://github.com/apache/guacamole-server/pull/214#discussion_r258929889
##########
File path: src/protocols/rdp/rdp_settings.c
##########
@@ -1007,6 +1023,16 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
IDX_LOAD_BALANCE_INFO, NULL);
#endif
+ /* Parse clipboard copy disable flag */
+ settings->disable_copy =
+ guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
+ IDX_DISABLE_COPY, 0);
Review comment:
Any particular reason, for the RDP flags, that you're parsing as `boolean`
but using `0` instead of `false` for the default? Looking at the other
protocols you've used `false` - not sure why this is different?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
