mike-jumper commented on a change in pull request #214: GUACAMOLE-381: Add
parameters for disabling clipboard copy/paste.
URL: https://github.com/apache/guacamole-server/pull/214#discussion_r259652831
##########
File path: src/protocols/rdp/rdp_settings.c
##########
@@ -1007,6 +1023,16 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
IDX_LOAD_BALANCE_INFO, NULL);
#endif
+ /* Parse clipboard copy disable flag */
+ settings->disable_copy =
+ guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
+ IDX_DISABLE_COPY, 0);
Review comment:
Yep - the FreeRDP library defines its own boolean type which breaks any code
using `stdbool.h`. We thus can't use the standard `bool` type in any code that
touches FreeRDP.
This is why the `enable_sftp` flag is an `int` in the RDP support:
https://github.com/apache/guacamole-server/blob/802e5b5547dc26f1fa7d0abba91570f87cfefb32/src/protocols/rdp/rdp_settings.h#L353
but is `bool` elsewhere:
https://github.com/apache/guacamole-server/blob/802e5b5547dc26f1fa7d0abba91570f87cfefb32/src/protocols/ssh/settings.h#L161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
