necouchman commented on a change in pull request #349: GUACAMOLE-678: Implement
new UriGuacamoleProperty
URL: https://github.com/apache/guacamole-client/pull/349#discussion_r268449218
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java
##########
@@ -58,11 +59,20 @@ public MySQLAuthenticationProviderModule(MySQLEnvironment
environment)
// Set the MySQL-specific properties for MyBatis.
myBatisProperties.setProperty("mybatis.environment.id", "guacamole");
- myBatisProperties.setProperty("JDBC.host",
environment.getMySQLHostname());
- myBatisProperties.setProperty("JDBC.port",
String.valueOf(environment.getMySQLPort()));
- myBatisProperties.setProperty("JDBC.schema",
environment.getMySQLDatabase());
- myBatisProperties.setProperty("JDBC.username",
environment.getMySQLUsername());
- myBatisProperties.setProperty("JDBC.password",
environment.getMySQLPassword());
+
+ // Check for URI
+ URI mySQLUri = environment.getMySQLUri();
Review comment:
Yeah, you're probably right - I'll refactor and pull this code out, and open
a separate JIRA issue for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
