mike-jumper commented on a change in pull request #219: GUACAMOLE-422: Add
timezone to client handshake
URL: https://github.com/apache/guacamole-server/pull/219#discussion_r268829988
##########
File path: src/protocols/ssh/settings.c
##########
@@ -425,6 +425,10 @@ guac_ssh_settings* guac_ssh_parse_args(guac_user* user,
settings->timezone =
guac_user_parse_args_string(user, GUAC_SSH_CLIENT_ARGS, argv,
IDX_TIMEZONE, NULL);
+
+ /* If timezone not explicitly set, try to pull from tunnel */
+ if (settings->timezone == NULL)
+ settings->timezone = user->info.timezone;
Review comment:
Same here as with RDP - later code relies on `settings->timezone` being
dynamically allocated. It would be better to leverage the default value logic
already provided by `guac_user_parse_args_string()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
