necouchman commented on a change in pull request #383: GUACAMOLE-715: Change
how null JDBC users are handled
URL: https://github.com/apache/guacamole-client/pull/383#discussion_r273613667
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserService.java
##########
@@ -392,8 +399,12 @@ public ModeledAuthenticatedUser
retrieveAuthenticatedUser(AuthenticationProvider
* The AuthenticatedUser to retrieve the corresponding ModeledUser of.
*
* @return
- * The ModeledUser which corresponds to the given AuthenticatedUser, or
- * null if no such user exists.
+ * The ModeledUser which corresponds to the given AuthenticatedUser, if
+ * the user exists in the database. If the user does not exist, and
+ * the module has been configured to require JDBC authentication via
+ * a "[db]-user-required" parameter, null will be returned. Otherwise
Review comment:
Yeah, you're right. I've taken a stab at redoing this way - creating a new
`retrieveSkeletonUser()` method in the `UserService` class, and then doing all
of the checks (that already happen, anyway) for configuration items in
`JDBCAUthenticationProviderSrevice`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
