necouchman commented on a change in pull request #389: GUACAMOLE-708: Enable
auto-creation of users in JDBC modules
URL: https://github.com/apache/guacamole-client/pull/389#discussion_r281221222
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserService.java
##########
@@ -401,25 +401,25 @@ public ModeledAuthenticatedUser
retrieveAuthenticatedUser(AuthenticationProvider
*/
public ModeledUser retrieveUser(AuthenticationProvider
authenticationProvider,
AuthenticatedUser authenticatedUser) throws GuacamoleException {
+
+ if (authenticatedUser == null)
Review comment:
The rest of the code in that method assumes that `authenticatedUser` is not
`null`. I think the IDE flagged it ]as a potential for `null`-dereferencing,
so I added a check. Will pull it out for now - since I'm not doing anything
else with this particular method it seems out of scope, now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
