necouchman commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r283149775
##########
File path:
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json
##########
@@ -195,6 +195,10 @@
{
"name" : "static-channels",
"type" : "TEXT"
+ },
+ {
+ "name" : "timezone",
+ "type" : "TIMEZONE"
Review comment:
According to this post that I found:
https://stackoverflow.com/questions/44582795/java-8-tz-database-time-zones
...the database shipped with Java is at least based on the same one as the
IANA/Olson/Tz Database (tzdb - https://en.wikipedia.org/wiki/Tz_database). My
guess is that it's a reasonably safe assumption that these will match up - or,
at the very least, that one is going to be just as out-of-date as another.
I'm happy to implement an `IANA_TIMEZONE` text field, as you suggest, if you
think that's the right way, but my gut feeling is that the net value of
implementing and maintaining it separately from the other timezones already
defined within the code is going to be small, and that, by and large, the
timezones already defined within the existing timezone field are going to work
fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
