mike-jumper commented on issue #225: Adding libs for guacenc URL: https://github.com/apache/guacamole-server/pull/225#issuecomment-498071100 @lshahar, as an aside, if you do decide to re-approach this as a separate image, please be sure to describe the nature of your commits at a high level going forward. Commit messages should be written with the intent of being useful to someone who wants to understand the purpose of your changes, particularly when looking at the git history sometime in the future. A message like "Update Dockerfile" (commit ef0561e) just duplicates what git already provides automatically. It doesn't add any information and doesn't capture your intent behind the change. It's particularly important to not fall into the trap of assuming the change itself is simple enough that anyone would understand your intent and reasoning by looking at the patch. That can only be true if the change is correct, and *that* is never a safe assumption.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
