mike-jumper opened a new pull request #410: GUACAMOLE-422: Allow arbitrary versions of the Guacamole protocol to be represented. URL: https://github.com/apache/guacamole-client/pull/410 This change migrates from the `GuacamoleProtocolVersion` enum defined via #348 to an identically-named class with static convenience constants. Using a class rather than an enum here allows for unknown, future versions of the Guacamole protocol to be represented and compared internally, even when the version of the API in use does not have a specific constant for those versions. Following through from there, this change also: * Adds a `getProtocolVersion()` getter to `ConfiguredGuacamoleSocket` such that the negotiated protocol version can be retrieved by users of that class. * Adds a unit test for `GuacamoleProtocolVersion` which verifies the parsing, string conversion, and comparison functionality. * Adds `equals()` to `GuacamoleProtocolVersion` so that users of the class can test for equality, and `hashCode()` since we're adding `equals()`. * Abstracts away the internal implementation of _how_ a version is tested for the presence of a particular capability, instead relying on `GuacamoleProtocolCapability` to perform that test. Part of this involved removing `getVersion()`. * Corrects a logic error within `atLeast()` that would have resulted in the comparison occasionally returning incorrect results.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
