mike-jumper opened a new pull request #411: GUACAMOLE-422: Use same display 
structure/mechanism for all locale preferences.
URL: https://github.com/apache/guacamole-client/pull/411
 
 
   With the addition of a time zone preference, the current locale preferences 
section uses two different mechanisms for rendering available fields: a 
hard-coded table containing, for the language, and a dynamic form leveraging 
the `guacFormField` directive, for the time zone. This results in both a DOM 
structure which does not represent the semantics of the section (a single form) 
and rendering issues (the time zone field spans multiple lines):
   
   
![guac-locale-preferences-001-before](https://user-images.githubusercontent.com/4632905/59556302-ef94de80-8f74-11e9-8fb2-ab0aeef97393.png)
   
   This change adds a new `LANGUAGE` field type and leverages that type to 
migrate to the `guacForm` directive for the whole locale section:
   
   
![guac-locale-preferences-002-after](https://user-images.githubusercontent.com/4632905/59556333-819ce700-8f75-11e9-840f-62164f53def3.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to