necouchman commented on a change in pull request #201: GUACAMOLE-547: Add
support for SSH NONE authentication method
URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294760441
##########
File path: src/common-ssh/ssh.c
##########
@@ -304,23 +304,30 @@ static int
guac_common_ssh_authenticate(guac_common_ssh_session* common_session)
LIBSSH2_SESSION* session = common_session->session;
/* Get user credentials */
- char* username = user->username;
- char* password = user->password;
guac_common_ssh_key* key = user->private_key;
/* Validate username provided */
- if (username == NULL) {
+ if (user->username == NULL) {
guac_client_abort(client, GUAC_PROTOCOL_STATUS_CLIENT_UNAUTHORIZED,
"SSH authentication requires a username.");
return 1;
}
/* Get list of supported authentication methods */
- char* user_authlist = libssh2_userauth_list(session, username,
- strlen(username));
+ char* user_authlist = libssh2_userauth_list(session, user->username,
+ strlen(user->username));
+
+ /* If auth list is NULL, then authentication has succeeded with NONE */
+ if (user_authlist == NULL) {
+ guac_client_log(client, GUAC_LOG_DEBUG,
+ "SSH NONE authentication succeeded.");
+ return 0;
+ }
+
guac_client_log(client, GUAC_LOG_DEBUG,
"Supported authentication methods: %s", user_authlist);
+
Review comment:
Ummm....because...
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
