mike-jumper commented on a change in pull request #201: GUACAMOLE-547: Add support for SSH NONE authentication method URL: https://github.com/apache/guacamole-server/pull/201#discussion_r294979656
########## File path: src/common-ssh/common-ssh/ssh.h ########## @@ -25,6 +25,20 @@ #include <guacamole/client.h> #include <libssh2.h> +/** + * Handler for retrieving additional credentials. + * + * @param client + * The Guacamole Client associated with this need for additional + * credentials. + * + * @param cred_name + * The name of the credential being requested, which will be shared + * with the client in order to generate a meaningful prompt. + * Review comment: Missing docs for the return value. If the returned string will eventually be freed with a call to `free()` and is thus required to be dynamically allocated, that should be documented as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
