Yes, fair comment! This business of adding extensions is fraught with difficulty ;)
You're right about using inline-block. My preferred solution would be to use flexbox, but that probably doesn't have quite high enough browser support for the project (96%). I can fix my extension by floating my control panel left. The block-sized <a> then takes up the rest of the line. It is far from ideal (don't really like float), but it works *and* leaves the <a> with block layout. Incidentally, if you want the same full width behaviour on the settings page, you could use that approach for the expander. But, again, I think flexbox would be a more robust solution. M. . On Mon, 17 Jun 2019 at 20:14, Mike Jumper <[email protected]> wrote: > @manolan1 <https://github.com/manolan1> - this is a pull request which is > closed, having been merged about a year ago, for an issue which has been > resolved and released. If you have questions on these changes, please use > the mailing list. > > ... wouldn't it have been better to change it to inline-block? > > No. The issue that this PR addressed was the size of the link not actually > matching the highlighted region, leading to confusion: > > https://issues.apache.org/jira/browse/GUACAMOLE-304 > > inline-block would not have produced the same behavior as block in that > respect. > > I ask because it broke one of my extensions ... > > If you would like to propose a change, feel free to open a new JIRA issue > and pull request with those changes. If there is a better way to achieve > this which also has a lower potential of breaking third-party styling, I > see no reason why that would not be merged. > > Be sure to describe what specifically broke. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/guacamole-client/pull/253?email_source=notifications&email_token=AB4VJ5HNUVIIWAZHXTUUELTP27PAJA5CNFSM4EQDZA72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4FLOA#issuecomment-502814136>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AB4VJ5BFZ2Z2IDOETV45E23P27PAJANCNFSM4EQDZA7Q> > . >
