necouchman commented on a change in pull request #303: GUACAMOLE-579: Get user
attributes from CAS ticket
URL: https://github.com/apache/guacamole-client/pull/303#discussion_r296062053
##########
File path:
guacamole-ext/src/main/java/org/apache/guacamole/token/TokenName.java
##########
@@ -63,35 +57,38 @@
/**
* This utility class should not be instantiated.
*/
- private TokenName() {}
+ protected TokenName() {}
/**
* Generates the name of the parameter token that should be populated with
- * the value of the given LDAP attribute. The name of the LDAP attribute
- * will automatically be transformed from "CamelCase", "headlessCamelCase",
+ * the value of the given attribute. The name of the attribute will
Review comment:
So, I removed the LDAP stuff, but kept the `fromAttribute()` name - it seems
like most of the extensions still call these attributes, so maybe it isn't too
specific? I'm open to suggestions, but seems okay to me...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
