m-khan-glyptodon commented on a change in pull request #419: GUACAMOLE-302:
Incorrect password field focus
URL: https://github.com/apache/guacamole-client/pull/419#discussion_r296908797
##########
File path: guacamole/src/main/webapp/app/form/templates/timeZoneField.html
##########
@@ -3,12 +3,14 @@
<!-- Available time zone regions -->
<select class="time-zone-region"
ng-disabled="disabled"
+ guac-focus="focused"
ng-model="region"
ng-options="name for name in regions | orderBy: name"></select>
<!-- Time zones within selected region -->
<select class="time-zone"
ng-disabled="disabled || !region"
+ guac-focus="focused"
Review comment:
The new approach that I believe is suitable for this field is to have the
`guac-focus` directive applied only to the "time-zone-region" and there are a
few reasons why I believe it is the right to do.
1. In most cases, it is impossible to determine which part of the field is
relevant so it makes sense to naturally focus the beginning of this field.
2. Also, the "time-zone" field is disabled until some content is selected in
the "time-zone-region". Because of this dependency, I think it is best to focus
the field that does not depend on the other.
3. And last but not the least, it is simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
