mike-jumper commented on issue #423: Guacamole-837: Add RDP keymap for Hungarian keyboard layout URL: https://github.com/apache/guacamole-client/pull/423#issuecomment-509030324 > The commit messages should probably be more descriptive (e.g. "Add Hungarian keyboard option to rdp.json"). There's a good blog post covering what makes a bad vs. good message here: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/ A good rule of thumb is to make sure the message provides high-level information not otherwise captured by git already. Messages like "Update rdp.json" and "Update en.json" only serve to duplicate what git already tells us in the diff and will not help someone looking through the logs, git blame, git bisect, etc. in the future. It should be possible to tell what you generally meant to do with your change from reading the commit messages, even if the changes themselves turn out to be incorrect some time in the future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
