mike-jumper commented on a change in pull request #426: GUACAMOLE-846:
tunnel.uuid not initialized if tunnel becomes UNSTABLE
URL: https://github.com/apache/guacamole-client/pull/426#discussion_r304135112
##########
File path: guacamole-common-js/src/main/webapp/modules/Tunnel.js
##########
@@ -1015,7 +1015,7 @@ Guacamole.WebSocketTunnel = function(tunnelURL) {
var opcode = elements.shift();
// Update state and UUID when first instruction received
- if (tunnel.state === Guacamole.Tunnel.State.CONNECTING) {
+ if (tunnel.state === Guacamole.Tunnel.State.CONNECTING ||
tunnel.uuid === null) {
Review comment:
If the issue is that the value of `tunnel.uuid` is being inadvertently
overly coupled to tunnel state, and that the tunnel UUID should be accepted
when sent via `INTERNAL_DATA_OPCODE` so long as it hasn't yet been set, perhaps
this should just be `if (!tunnel.uuid)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
