necouchman opened a new pull request #228: GUACAMOLE-221: Implement guacd support for prompting URL: https://github.com/apache/guacamole-server/pull/228 Okay, here we go...this pull request implements support for two major components of getting Guacamole to support prompting: * Support for sending the "required" instruction to the client, along with whatever is being required. * Support for reading back the required input from the client via the argv instruction, including various handlers for the protocols to handle (mostly authentication) data sent back. I've tested where I can to try to make sure everything works - RDP and SSH seem to be good (along with some client changes that I'll need to clean up and submit, soon). I don't have a great VNC setup to try that out with, but I tested what I could. Also, at this moment this change does not handle collecting and sending multiple required parameters, and then reading them back concurrently - it does things one at a time. I know that was part of the discussion somewhere (other PR, mailing list - something), so I'm happy to take a stab at that, too, but wanted to get some other eyes on this code, first. Also, I'm not sure if this particular change warrants a rev of the protocol version introduced in 1.1.0 - it does add the `required` instruction??
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
