mike-jumper commented on a change in pull request #435: GUACAMOLE-630: Allow 
parameters received via "argv" streams to be edited within the Guacamole menu.
URL: https://github.com/apache/guacamole-client/pull/435#discussion_r312317344
 
 

 ##########
 File path: guacamole/src/main/webapp/app/client/templates/client.html
 ##########
 @@ -96,6 +96,15 @@ <h3>{{'CLIENT.SECTION_HEADER_DEVICES' | translate}}</h3>
                     </div>
                 </div>
 
+                <!-- Connection parameters which may be modified while the 
connection is open -->
+                <div class="menu-section connection-parameters" 
id="connection-settings" ng-show="client.protocol">
+                    <guac-form 
namespace="getProtocolNamespace(client.protocol)"
+                               content="client.forms"
+                               model="menu.connectionParameters"
+                               model-only="true"
+                               data-disabled="true"></guac-form>
 
 Review comment:
   I ... don't know. I will check, but I'm pretty sure it shouldn't be. This 
might be from testing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to