necouchman commented on issue #228: GUACAMOLE-221: Implement guacd support for 
prompting
URL: https://github.com/apache/guacamole-server/pull/228#issuecomment-520179986
 
 
   @mike-jumper: Well, most of that was pretty straight-forward on the server 
side, but not entirely sure how to handle multiple values being sent.  The RDP 
code is probably the best current example of this - the way it's constructed 
right now:
   * guacd sends parameters to client that need to be input.
   * RDP authentication callback kicks off `pthread_cond_wait` waiting for 
request to be filled.
   * Prompts are presented to the client, which sends them back one at a time.
   * argv handler triggers completion via the `pthread_cond_broadcast` as soon 
one of the parameters is received.
   
   I don't think it's going to work the way I currently have it implemented 
because the thread is going to continue as soon as the first value is received, 
and not wait for the remaining ones.  Any suggestions on how I should proceed 
that would satisfy all of the following:
   * Allow multiple parameters to be both requested (guacd -> client) and 
received (client->guacd) in a single shot
   * Allow callback functions of the various libraries to be used.
   * Allow for the returned username, password, and/or domain (in the case of 
RDP) to be empty strings.
   
   ??

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to