necouchman commented on a change in pull request #439: GUACAMOLE-234: Fix
resource leaks in new LDAP code.
URL: https://github.com/apache/guacamole-client/pull/439#discussion_r313017712
##########
File path:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
##########
@@ -223,10 +224,11 @@ else if (results.isReferral() &&
request.isFollowReferrals()) {
}
+ results.close();
Review comment:
Okay, gave this another shot with a `try...finally` block. I don't like the
nested `try` statements - I could declare the `results` variable outside of the
first `try` block, instead, if you think that would be a better route?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
