mike-jumper opened a new pull request #442: GUACAMOLE-630: Use singleton 
instance of Pickr for all color input fields.
URL: https://github.com/apache/guacamole-client/pull/442
 
 
   This change adds a new service, `colorPickerService`, which abstracts away a 
singleton instance of Pickr which is initialized at page startup. The 
`guacInputColor` directive has been refactored to leverage this service rather 
than instantiate Pickr itself, thus avoiding lengthy initialization delays 
multiplied by the number of color fields.
   
   Part of this involved modifying `formService` to only create injectors as 
necessary. Creating an injector causes services, providers, etc. in the modules 
of that injector to be initialized, breaking expectations if those modules have 
actually already been loaded.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to