necouchman commented on a change in pull request #433: GUACAMOLE-514:
Client-side fields and translations for VNC authentication enhancements
URL: https://github.com/apache/guacamole-client/pull/433#discussion_r317338538
##########
File path: guacamole/src/main/webapp/translations/en.json
##########
@@ -677,6 +677,7 @@
"FIELD_HEADER_SFTP_ROOT_DIRECTORY" : "File browser root
directory:",
"FIELD_HEADER_SFTP_USERNAME" : "Username:",
"FIELD_HEADER_SWAP_RED_BLUE" : "Swap red/blue components:",
+ "FIELD_HEADER_USERNAME" : "Username:",
Review comment:
Definitely - I've shamelessly copied the Telnet protocol version of the
translation for each language to the VNC protocol. Two things I noticed as I
was doing this:
* There is some level of inconsistency within the translations as to whether
they are organized alphabetically or logically. I tried to be consistent
within the inconsistency - but I can try to correct the inconsistency if you'd
rather.
* The Italian translation looks like most of the items probably need to be
removed - I don't think they're actually translated. Again, I just copied it
and carried on, but if it's a good time to strip out untranslated strings
within that translation, I can go for that...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
