mike-jumper commented on a change in pull request #238: GUACAMOLE-625: Included
Latin American keymap
URL: https://github.com/apache/guacamole-server/pull/238#discussion_r329336072
##########
File path: src/protocols/rdp/Makefile.am
##########
@@ -268,6 +268,7 @@ rdp_keymaps = \
$(srcdir)/keymaps/en_gb_qwerty.keymap \
$(srcdir)/keymaps/en_us_qwerty.keymap \
$(srcdir)/keymaps/es_es_qwerty.keymap \
+ $(srcdir)/keymaps/latam_qwerty.keymap \
Review comment:
I agree that we should prefer to remain consistent with the existing
convention (`[language code]-[country code]-[variant]`) or, if that isn't
working any longer in practice, investigate whether we should be using a
different convention.
Following current convention, if "latam" is the proper identifier for all
countries associated with this keyboard layout, it sounds like the layout
identifier that follows our convention would be `es-latam-qwerty`.
**BUT**, from the [forum thread linked
above](https://askubuntu.com/questions/8797/what-is-the-two-character-language-code-for-the-latin-american-keyboard-layout),
we may want to look into a better system:
> ... That aside, I would recommend against using language codes to indicate
keyboard layouts. There is a separate system already in place for abbreviating
the names of the layouts themselves. See `shortDescription` in
[xkb-data](http://packages.ubuntu.com/maverick/xkb-data)'s `base.xml`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
