mike-jumper commented on a change in pull request #237: GUACAMOLE-871: Add
support for hidden cursor (DECTECM)
URL: https://github.com/apache/guacamole-server/pull/237#discussion_r335591156
##########
File path: src/terminal/terminal.c
##########
@@ -777,31 +778,42 @@ void guac_terminal_commit_cursor(guac_terminal* term) {
guac_terminal_char* guac_char;
- guac_terminal_buffer_row* old_row;
- guac_terminal_buffer_row* new_row;
+ guac_terminal_buffer_row* row;
/* If no change, done */
- if (term->visible_cursor_row == term->cursor_row &&
term->visible_cursor_col == term->cursor_col)
+ if (term->cursor_visible && term->visible_cursor_row == term->cursor_row
&& term->visible_cursor_col == term->cursor_col)
Review comment:
Don't worry - no counting of CPU cycles is happening in this case. Orders of
magnitude of cycles, sure, but this isn't a performance-critical region of code
where individual cycles would have huge multipliers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
