necouchman commented on issue #450: GUACOMOLE-300: Support posixGroup in LDAP Authentication and Group-based Session Admission URL: https://github.com/apache/guacamole-client/pull/450#issuecomment-543773060 @mlewissmith: Looks much better. A couple of things off the bat: * Several of your commits lack the "GUACAMOLE-300" prefix - all commits should have it. * There are a couple of rebranch and merge commits. These should be eliminated. * Probably worth squashing a bunch of the commits into a smaller number of them, as there are quite a few commits for the relatively small amount of code changing. * Please double-check style - overall it looked okay, but there were a couple of places where you used cuddled `if...else` statements (`} else {`).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
