mike-jumper commented on issue #452: GUACAMOLE-234: Make LDAP user and group identifiers lowercase. URL: https://github.com/apache/guacamole-client/pull/452#issuecomment-546628362 First, as you note, I'm not sure this is the right issue for this. Is there a reason why this should be part of [GUACAMOLE-234](https://issues.apache.org/jira/browse/GUACAMOLE-234)? As for the implementation itself, I think this may be problematic: * LDAP DNs may be case-insensitive by default, but I don't believe this is required nor guaranteed. If the LDAP implementation is configured to be case-sensitive, I think we should honor that. * It is not guaranteed that the database will be case-sensitive (I don't believe MySQL is case sensitive), nor that all usernames within a case-sensitive database will be lowercase. I think it boils down to the overall definition of identity as dictated by the administrator/system. Guacamole may be deployed in environments where usernames are case-sensitive or case-insensitive, and Guacamole's definition of identity should be configurable to the extent that it can be compatible with either. Off the top of my head, one possibility might be to provide an option within the JDBC auth which defines whether usernames are case-sensitive. Another might be to provide a global option at the `Environment` level.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
